| Summary: | Check for git-svn so further commands don't die with strange error messages. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim 'mithro' Ansell <mithro> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED WONTFIX | ||||||
| Severity: | Normal | CC: | abarth, dpranke, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim 'mithro' Ansell
2013-01-02 21:19:58 PST
Created attachment 181143 [details]
Patch
Comment on attachment 181143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review > Tools/Scripts/webkitpy/common/checkout/scm/git.py:67 > + self._check_git_svn() git svn isn't strictly necessary for all webkit-patch operations. For example, I don't think the EWS bots have git-svn installed (since they never need to talk to svn). Maybe we should run this check before trying to use git svn ? Comment on attachment 181143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review >> Tools/Scripts/webkitpy/common/checkout/scm/git.py:67 >> + self._check_git_svn() > > git svn isn't strictly necessary for all webkit-patch operations. For example, I don't think the EWS bots have git-svn installed (since they never need to talk to svn). Maybe we should run this check before trying to use git svn ? Adam is right; we shouldn't require git-svn for everything, just for the things that need it. Abandoning this change. |