Bug 105994

Summary: Check for git-svn so further commands don't die with strange error messages.
Product: WebKit Reporter: Tim 'mithro' Ansell <mithro>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review-, dpranke: commit-queue-

Tim 'mithro' Ansell
Reported 2013-01-02 21:19:58 PST
Check for git-svn so further commands don't die with strange error messages.
Attachments
Patch (2.32 KB, patch)
2013-01-02 21:20 PST, Tim 'mithro' Ansell 		dpranke: review-
dpranke: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim 'mithro' Ansell
Comment 1 2013-01-02 21:20:28 PST
Created attachment 181143 [details] Patch
Adam Barth
Comment 2 2013-01-03 13:33:39 PST
Comment on attachment 181143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review > Tools/Scripts/webkitpy/common/checkout/scm/git.py:67 > + self._check_git_svn() git svn isn't strictly necessary for all webkit-patch operations. For example, I don't think the EWS bots have git-svn installed (since they never need to talk to svn). Maybe we should run this check before trying to use git svn ?
Dirk Pranke
Comment 3 2013-01-09 18:45:59 PST
Comment on attachment 181143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181143&action=review >> Tools/Scripts/webkitpy/common/checkout/scm/git.py:67 >> + self._check_git_svn() > > git svn isn't strictly necessary for all webkit-patch operations. For example, I don't think the EWS bots have git-svn installed (since they never need to talk to svn). Maybe we should run this check before trying to use git svn ? Adam is right; we shouldn't require git-svn for everything, just for the things that need it.
Tim 'mithro' Ansell
Comment 4 2013-03-04 17:12:00 PST
Abandoning this change.
Note You need to log in before you can comment on or make changes to this bug.