Bug 105993 – Remove superfluous 'IntPoint toPoint(const IntSize&)'

• Component: New Bugs
• Status: RESOLVED FIXED

[Steve Block]

Remove superfluous 'IntPoint toPoint(const IntSize&)'

[Steve Block]

Created attachment 181144 [details]
Patch

[Steve Block]

Note that 'IntPoint toPoint(const IntSize&)' was added in http://trac.webkit.org/changeset/55090

[Steve Block]

Both IntPoint and FloatPoint provide explicit constructors to create objects from IntSize and FloatSize respectively. It would be good to be consistent in using these constructors, rather than toPoint().

[Eric Seidel (no email)]

Comment on attachment 181144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181144&action=review

LGTM.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2171
>      IntSize offsetPoint = point - roundedIntPoint(boundingBoxRect().location());

This variable is confusingly named. :)

[Eric Seidel (no email)]

I didn't mark it r+ since you didn't mark it r? :)

[Steve Block]

Created attachment 181152 [details]
Patch

[Steve Block]

Thanks

> This variable is confusingly named. :)
Done

(I was waiting for the bots before marking r?)

[Steve Block]

Comment on attachment 181152 [details]
Patch

Using Eric's LGTM

[WebKit Review Bot]

Comment on attachment 181152 [details]
Patch

Rejecting attachment 181152 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 181152 [details]
Patch

Rejecting attachment 181152 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 181152 [details]
Patch

Clearing flags on attachment: 181152

Committed r138701: <http://trac.webkit.org/changeset/138701>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.