Summary: | Substrings of a string from literal should be a string from literal | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | Web Template Framework | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED LATER | ||||||
Severity: | Normal | CC: | ap, ojan.autocc, webkit.review.bot | ||||
Priority: | P2 | Keywords: | EasyFix | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2013-01-02 19:33:42 PST
Created attachment 181138 [details]
Patch
Comment on attachment 181138 [details] Patch Attachment 181138 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15649547 New failing tests: svg/as-image/img-preserveAspectRatio-support-2.html When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches? (In reply to comment #3) > When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches? It is indeed not worth it yet. |