Bug 105990

Summary:

Substrings of a string from literal should be a string from literal

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

Web Template Framework

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED LATER

Severity:

Normal

CC:

ap, ojan.autocc, webkit.review.bot

Priority:

Keywords:

EasyFix

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-

Description Benjamin Poulain 2013-01-02 19:33:42 PST

Let's use a little less memory....

Comment 1 Benjamin Poulain 2013-01-02 20:08:53 PST

Created attachment 181138 [details]
Patch

Comment 2 Build Bot 2013-01-02 21:59:51 PST

Comment on attachment 181138 [details]
Patch

Attachment 181138 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15649547

New failing tests:
svg/as-image/img-preserveAspectRatio-support-2.html

Comment 3 Alexey Proskuryakov 2013-01-03 10:05:15 PST

When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches?

Comment 4 Benjamin Poulain 2013-01-03 13:33:57 PST

(In reply to comment #3)
> When are we creating substrings of literal strings? Is that common enough for memory savings to offset performance cost of extra branches?

It is indeed not worth it yet.