Bug 105974

Summary: [chromium] Remove unused transitional #defines from WebKit Client API
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Robinson
Reported Thursday, January 3, 2013 1:06:21 AM UTC
[chromium] Remove unused transitional #defines from WebKit Client API
Attachments
Patch (3.35 KB, patch)
2013-01-02 17:07 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 Thursday, January 3, 2013 1:07:50 AM UTC
Created attachment 181114 [details] Patch
James Robinson
Comment 2 Thursday, January 3, 2013 1:08:19 AM UTC
Comment on attachment 181114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181114&action=review > Source/WebKit/chromium/public/WebWidget.h:43 > #define WEBWIDGET_HAS_SETCOMPOSITORSURFACEREADY 1 > #define WEBWIDGET_HAS_PAINT_OPTIONS 1 These two are still checked on the chromium side, so I'll have to remove the checks, roll forward, then remove the #defines
Adam Barth
Comment 3 Thursday, January 3, 2013 1:08:49 AM UTC
Comment on attachment 181114 [details] Patch Thanks!
WebKit Review Bot
Comment 4 Thursday, January 3, 2013 1:12:12 AM UTC
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 5 Thursday, January 3, 2013 2:06:33 AM UTC
Comment on attachment 181114 [details] Patch Clearing flags on attachment: 181114 Committed r138690: <http://trac.webkit.org/changeset/138690>
WebKit Review Bot
Comment 6 Thursday, January 3, 2013 2:06:37 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.