Bug 105974 - [chromium] Remove unused transitional #defines from WebKit Client API
Summary: [chromium] Remove unused transitional #defines from WebKit Client API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-02 17:06 PST by James Robinson
Modified: 2013-01-02 18:06 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.35 KB, patch)
2013-01-02 17:07 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-01-02 17:06:21 PST
[chromium] Remove unused transitional #defines from WebKit Client API
Comment 1 James Robinson 2013-01-02 17:07:50 PST
Created attachment 181114 [details]
Patch
Comment 2 James Robinson 2013-01-02 17:08:19 PST
Comment on attachment 181114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181114&action=review

> Source/WebKit/chromium/public/WebWidget.h:43
>  #define WEBWIDGET_HAS_SETCOMPOSITORSURFACEREADY 1
>  #define WEBWIDGET_HAS_PAINT_OPTIONS 1

These two are still checked on the chromium side, so I'll have to remove the checks, roll forward, then remove the #defines
Comment 3 Adam Barth 2013-01-02 17:08:49 PST
Comment on attachment 181114 [details]
Patch

Thanks!
Comment 4 WebKit Review Bot 2013-01-02 17:12:12 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 WebKit Review Bot 2013-01-02 18:06:33 PST
Comment on attachment 181114 [details]
Patch

Clearing flags on attachment: 181114

Committed r138690: <http://trac.webkit.org/changeset/138690>
Comment 6 WebKit Review Bot 2013-01-02 18:06:37 PST
All reviewed patches have been landed.  Closing bug.