WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105974
[chromium] Remove unused transitional #defines from WebKit Client API
https://bugs.webkit.org/show_bug.cgi?id=105974
Summary
[chromium] Remove unused transitional #defines from WebKit Client API
James Robinson
Reported
2013-01-02 17:06:21 PST
[chromium] Remove unused transitional #defines from WebKit Client API
Attachments
Patch
(3.35 KB, patch)
2013-01-02 17:07 PST
,
James Robinson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2013-01-02 17:07:50 PST
Created
attachment 181114
[details]
Patch
James Robinson
Comment 2
2013-01-02 17:08:19 PST
Comment on
attachment 181114
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=181114&action=review
> Source/WebKit/chromium/public/WebWidget.h:43 > #define WEBWIDGET_HAS_SETCOMPOSITORSURFACEREADY 1 > #define WEBWIDGET_HAS_PAINT_OPTIONS 1
These two are still checked on the chromium side, so I'll have to remove the checks, roll forward, then remove the #defines
Adam Barth
Comment 3
2013-01-02 17:08:49 PST
Comment on
attachment 181114
[details]
Patch Thanks!
WebKit Review Bot
Comment 4
2013-01-02 17:12:12 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
WebKit Review Bot
Comment 5
2013-01-02 18:06:33 PST
Comment on
attachment 181114
[details]
Patch Clearing flags on attachment: 181114 Committed
r138690
: <
http://trac.webkit.org/changeset/138690
>
WebKit Review Bot
Comment 6
2013-01-02 18:06:37 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug