Bug 105943

Summary:

Canvas blending tests fail on Mac WK2

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Canvas

Assignee:

Rik Cabanier <cabanier>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cabanier, krit, mihnea, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

100069

Attachments:

Description	Flags
Patch	none
Patch	none

Ryosuke Niwa

Reported 2013-01-02 14:01:52 PST

It appears that http://trac.webkit.org/changeset/138334 didn’t update the WK2 code properly.

Attachments
Patch (3.08 KB, patch) 2013-01-03 11:04 PST, Rik Cabanier	no flags	Details Formatted Diff Diff
Patch (6.20 KB, patch) 2013-01-03 11:32 PST, Rik Cabanier	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-01-02 14:34:33 PST

Added a test expectation in http://trac.webkit.org/changeset/138643. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcanvas%2Fcanvas-blend-image.html%2Cfast%2Fcanvas%2Fcanvas-blend-solid.html http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138637%20(4403)/fast/canvas/canvas-blend-image-pretty-diff.html http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138637%20(4403)/fast/canvas/canvas-blend-image-pretty-diff.html

Simon Fraser (smfr)

Comment 2 2013-01-02 21:50:43 PST

There should be no WK2-specific canvas code. Maybe this is the issue where composited content has color matching issues?

Rik Cabanier

Comment 3 2013-01-02 22:45:36 PST

(In reply to comment #2) > There should be no WK2-specific canvas code. Maybe this is the issue where composited content has color matching issues? It seems that the preference is not passed to the WebKitProcess so it always executes as accelerated, even when turned off.

Rik Cabanier

Comment 4 2013-01-03 11:04:00 PST

Created attachment 181192 [details] Patch

Simon Fraser (smfr)

Comment 5 2013-01-03 11:07:09 PST

Comment on attachment 181192 [details] Patch InternalSettings::Backup need to save/restore this pref too.

Rik Cabanier

Comment 6 2013-01-03 11:11:22 PST

(In reply to comment #5) > (From update of attachment 181192 [details]) > InternalSettings::Backup need to save/restore this pref too. will do

Rik Cabanier

Comment 7 2013-01-03 11:32:59 PST

Created attachment 181194 [details] Patch

Ryosuke Niwa

Comment 8 2013-01-03 11:45:02 PST

Comment on attachment 181194 [details] Patch Excellent! Thanks for the timely fix!

WebKit Review Bot

Comment 9 2013-01-03 12:06:05 PST

Comment on attachment 181194 [details] Patch Clearing flags on attachment: 181194 Committed r138726: <http://trac.webkit.org/changeset/138726>

WebKit Review Bot

Comment 10 2013-01-03 12:06:10 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.