Bug 105913 – Regression(r138603): Caused 2 webkitpy tests to fail

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Chris Dumez]

<http://trac.webkit.org/changeset/138603> caused 2 webkitpy tests to fail:
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

Checking autoinstalled packages ...
Checking imports ...
Finding the individual test methods ...
Running the tests ...
11[839/1617] webkitpy.tool.bot.ircbot_unittest.IRCBotTest.test_help failed:
  Traceback (most recent call last):
    File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py", line 92, in test_help
      OutputCapture().assert_outputs(self, run, args=["help"], expected_logs=expected_logs)
    File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/common/system/outputcapture.py", line 100, in assert_outputs
      testcase.assertEqual(logs_string, expected_logs)
  AssertionError: 'MOCK: irc.post: mock_nick: Available commands: create-bug, help, hi, restart, roll-chromium-deps, rollout, sheriffs, whois\n' != 'MOCK: irc.post: mock_nick: Available commands: create-bug, help, hi, restart, roll-chromium-deps, rollout, whois\n'
  
[1308/1617] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_sheriffs failed:
  Traceback (most recent call last):
    File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py", line 69, in test_sheriffs
      sheriffs.execute("tom", [self._sheriff_test_data_url("0")], None, None))
  AssertionError: 'tom: There are no Chromium Webkit sheriffs currently assigned.' != 'tom: Failed to parse URL: file:///home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/webkitpy/tool/bot/testdata/webkit_sheriff_0.js'
  
Ran 1617 tests in 2.927s
FAILED (failures=2, errors=0)

[Chris Dumez]

Created attachment 181022 [details]
Patch

[Thiago Marcos P. Santos]

LGTM.

[Kentaro Hara]

Comment on attachment 181022 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 181022 [details]
Patch

Clearing flags on attachment: 181022

Committed r138617: <http://trac.webkit.org/changeset/138617>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Thanks. :)

[Alan Cutter]

Thanks for fixing this slip up of mine. I realise now that I wasn't running the right command to run the tests.