Bug 105897

Summary: [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ap: review+
Patch for landing none

Chris Dumez
Reported 2013-01-01 06:06:48 PST
plugins/clicking-missing-plugin-fires-delegate.html is failing on WK2 due to missing WebKitTestRunner dumping: diff: - MISSING PLUGIN BUTTON PRESSED
Attachments
Patch (5.38 KB, patch)
2013-01-01 06:10 PST, Chris Dumez 		ap: review+
DetailsFormatted DiffDiff
Patch for landing (5.30 KB, patch)
2013-01-01 22:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-01 06:10:48 PST
Created attachment 180990 [details] Patch
Alexey Proskuryakov
Comment 2 2013-01-01 20:45:03 PST
Comment on attachment 180990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180990&action=review > Tools/WebKitTestRunner/TestController.cpp:1112 > +void TestController::unavailablePluginButtonClicked(WKPageRef, WKPluginUnavailabilityReason, WKStringRef /*mimeType*/, WKStringRef /*url*/, WKStringRef /*pluginsPageURL*/, const void*) I would leave arguments names completely, not just comment them out. They are not even present in header.
Chris Dumez
Comment 3 2013-01-01 22:37:42 PST
Created attachment 181009 [details] Patch for landing Removed commented argument names.
WebKit Review Bot
Comment 4 2013-01-01 22:54:43 PST
Comment on attachment 181009 [details] Patch for landing Clearing flags on attachment: 181009 Committed r138608: <http://trac.webkit.org/changeset/138608>
WebKit Review Bot
Comment 5 2013-01-01 22:54:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.