Summary: | Add supplementability for WebContext | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sam Weinig
2012-12-30 18:45:39 PST
Created attachment 180962 [details]
Patch
Comment on attachment 180962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review > Source/WebKit2/UIProcess/API/C/WKContext.cpp:39 > + ! Committed r138599: <http://trac.webkit.org/changeset/138599> Comment on attachment 180962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review I was curious about the approach, and I noticed one nit below. Please feel free to ignore my nitpicking. :) > Source/WebKit2/UIProcess/WebContextSupplement.h:36 > + WebContextSupplement(WebContext* context) One-argument constructors should use the "explicit" keyword (unless you really wan the implicit conversions, which seems unlikely here) (In reply to comment #4) > (From update of attachment 180962 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review > > I was curious about the approach, and I noticed one nit below. Please feel free to ignore my nitpicking. :) I just trying to break things up into to existing abstractions right now, not much approach going on. > > > Source/WebKit2/UIProcess/WebContextSupplement.h:36 > > + WebContextSupplement(WebContext* context) > > One-argument constructors should use the "explicit" keyword (unless you really wan the implicit conversions, which seems unlikely here) Indeed, will fix. |