Bug 105878

Summary: Add supplementability for WebContext
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Sam Weinig
Reported 2012-12-30 18:45:39 PST
Add supplementability for WebContext
Attachments
Patch (21.01 KB, patch)
2012-12-30 18:46 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-12-30 18:46:39 PST
Created attachment 180962 [details] Patch
mitz
Comment 2 2012-12-31 11:47:21 PST
Comment on attachment 180962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review > Source/WebKit2/UIProcess/API/C/WKContext.cpp:39 > + !
Sam Weinig
Comment 3 2012-12-31 11:54:39 PST
Committed r138599: <http://trac.webkit.org/changeset/138599>
Adam Barth
Comment 4 2013-01-02 00:40:16 PST
Comment on attachment 180962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review I was curious about the approach, and I noticed one nit below. Please feel free to ignore my nitpicking. :) > Source/WebKit2/UIProcess/WebContextSupplement.h:36 > + WebContextSupplement(WebContext* context) One-argument constructors should use the "explicit" keyword (unless you really wan the implicit conversions, which seems unlikely here)
Sam Weinig
Comment 5 2013-01-02 09:59:07 PST
(In reply to comment #4) > (From update of attachment 180962 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180962&action=review > > I was curious about the approach, and I noticed one nit below. Please feel free to ignore my nitpicking. :) I just trying to break things up into to existing abstractions right now, not much approach going on. > > > Source/WebKit2/UIProcess/WebContextSupplement.h:36 > > + WebContextSupplement(WebContext* context) > > One-argument constructors should use the "explicit" keyword (unless you really wan the implicit conversions, which seems unlikely here) Indeed, will fix.
Note You need to log in before you can comment on or make changes to this bug.