| Summary: | Move pointer to Document up from SelectorChecker to StyleResolver. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | allan.jensen, cmarcelo, eric, kling, koivisto, macpherson, menard, ojan.autocc, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 89879 | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2012-12-29 14:19:12 PST
Created attachment 180945 [details]
Patch
Comment on attachment 180945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review Looks reasonable. > Source/WebCore/css/SelectorChecker.h:104 > + bool checkScrollbarPseudoClass(Document*, CSSSelector*) const; Does this method belong on SelectorChecker? It seems odd to be the only method which takes a Document pointer. (In reply to comment #2) > (From update of attachment 180945 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review > > Looks reasonable. > > > Source/WebCore/css/SelectorChecker.h:104 > > + bool checkScrollbarPseudoClass(Document*, CSSSelector*) const; > > Does this method belong on SelectorChecker? It seems odd to be the only method which takes a Document pointer. This guy definitely needs to be refactored. I haven't figured out how to untangle this properly yet, but I am thinking about it :) Comment on attachment 180945 [details] Patch Clearing flags on attachment: 180945 Committed r138571: <http://trac.webkit.org/changeset/138571> All reviewed patches have been landed. Closing bug. |