Bug 105863

Summary: Move pointer to Document up from SelectorChecker to StyleResolver.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, kling, koivisto, macpherson, menard, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2012-12-29 14:19:12 PST
Move pointer to Document up from SelectorChecker to StyleResolver.
Attachments
Patch (19.40 KB, patch)
2012-12-29 14:27 PST, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2012-12-29 14:27:16 PST
Created attachment 180945 [details] Patch
Eric Seidel (no email)
Comment 2 2012-12-29 14:41:17 PST
Comment on attachment 180945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review Looks reasonable. > Source/WebCore/css/SelectorChecker.h:104 > + bool checkScrollbarPseudoClass(Document*, CSSSelector*) const; Does this method belong on SelectorChecker? It seems odd to be the only method which takes a Document pointer.
Dimitri Glazkov (Google)
Comment 3 2012-12-29 14:45:42 PST
(In reply to comment #2) > (From update of attachment 180945 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review > > Looks reasonable. > > > Source/WebCore/css/SelectorChecker.h:104 > > + bool checkScrollbarPseudoClass(Document*, CSSSelector*) const; > > Does this method belong on SelectorChecker? It seems odd to be the only method which takes a Document pointer. This guy definitely needs to be refactored. I haven't figured out how to untangle this properly yet, but I am thinking about it :)
WebKit Review Bot
Comment 4 2012-12-29 16:31:07 PST
Comment on attachment 180945 [details] Patch Clearing flags on attachment: 180945 Committed r138571: <http://trac.webkit.org/changeset/138571>
WebKit Review Bot
Comment 5 2012-12-29 16:31:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.