Bug 105863 - Move pointer to Document up from SelectorChecker to StyleResolver.
Summary: Move pointer to Document up from SelectorChecker to StyleResolver.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 89879
  Show dependency tree / graph
 
Reported: 2012-12-29 14:19 PST by Dimitri Glazkov (Google)
Modified: 2012-12-29 16:31 PST (History)
9 users (show)

See Also:

Attachments
Patch (19.40 KB, patch)
2012-12-29 14:27 PST, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2012-12-29 14:19:12 PST 
Move pointer to Document up from SelectorChecker to StyleResolver.
Comment 1 Dimitri Glazkov (Google) 2012-12-29 14:27:16 PST 
Created attachment 180945 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-12-29 14:41:17 PST 
Comment on attachment 180945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review

Looks reasonable.

> Source/WebCore/css/SelectorChecker.h:104
> +    bool checkScrollbarPseudoClass(Document*, CSSSelector*) const;

Does this method belong on SelectorChecker?  It seems odd to be the only method which takes a Document pointer.
Comment 3 Dimitri Glazkov (Google) 2012-12-29 14:45:42 PST 
(In reply to comment #2)
> (From update of attachment 180945 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180945&action=review
> 
> Looks reasonable.
> 
> > Source/WebCore/css/SelectorChecker.h:104
> > +    bool checkScrollbarPseudoClass(Document*, CSSSelector*) const;
> 
> Does this method belong on SelectorChecker?  It seems odd to be the only method which takes a Document pointer.

This guy definitely needs to be refactored. I haven't figured out how to untangle this properly yet, but I am thinking about it :)
Comment 4 WebKit Review Bot 2012-12-29 16:31:07 PST 
Comment on attachment 180945 [details]
Patch

Clearing flags on attachment: 180945

Committed r138571: <http://trac.webkit.org/changeset/138571>
Comment 5 WebKit Review Bot 2012-12-29 16:31:11 PST 
All reviewed patches have been landed.  Closing bug.