Summary: | getComputedStyle returns "left" instead of "none" for "float" on abspos elements | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Sherov <mike.sherov> | ||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | allan.jensen, cmarcelo, macpherson, menard, ojan.autocc, tony, udaykiran4u, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
URL: | http://jsfiddle.net/ChPCD/7/ | ||||||||||||
Attachments: |
|
Description
Mike Sherov
2012-12-28 11:12:14 PST
Created attachment 184924 [details]
Proposed patch
Comment on attachment 184924 [details]
Proposed patch
I mentioned on IRC that CSSComputedStyleDeclaration.cpp might be a better place for this type of change since we don't need to change the style for rendering.
Created attachment 185008 [details]
Patch
Fixed review comments.
Created attachment 185014 [details]
Patch
Comment on attachment 185014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185014&action=review > LayoutTests/ChangeLog:10 > + If 'position' has the value absolute, page or fixed, and the value of float is > + left or right, the box is absolutely positioned and the computed value of float is none. > + http://www.w3.org/TR/css3-positioning/#dis-pos-flo Please mention that this matches Firefox and IE. BTW, do you know of any websites that depend on this behavior? Created attachment 185027 [details]
Patch
Updated ChangeLog
Thanks for review. (In reply to comment #5) > (From update of attachment 185014 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185014&action=review > > > LayoutTests/ChangeLog:10 > > + If 'position' has the value absolute, page or fixed, and the value of float is > > + left or right, the box is absolutely positioned and the computed value of float is none. > > + http://www.w3.org/TR/css3-positioning/#dis-pos-flo > > Please mention that this matches Firefox and IE. BTW, do you know of any websites that depend on this behavior? Fixed ChangeLog. Sorry I am not aware of websites. Can I carry-forward your r+ to next patch? If yes, how do I do it with webkit-patch? Comment on attachment 185027 [details]
Patch
When the previous patch still had r+, you can use 'webkit-patch land-safely' to forward on the review flag.
(In reply to comment #8) > (From update of attachment 185027 [details]) > When the previous patch still had r+, you can use 'webkit-patch land-safely' to forward on the review flag. Thanks. Will remember it from next time :) Comment on attachment 185027 [details] Patch Clearing flags on attachment: 185027 Committed r140993: <http://trac.webkit.org/changeset/140993> All reviewed patches have been landed. Closing bug. |