Bug 105829

Summary: Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters style
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Andrey Lushnikov 2012-12-28 06:58:38 PST
Refactor DefaultTextEditor's classes to loosen their coupling.
Comment 1 Andrey Lushnikov 2012-12-28 07:04:42 PST
Created attachment 180871 [details]
Patch
Comment 2 Pavel Feldman 2012-12-28 07:51:13 PST
Comment on attachment 180871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180871&action=review

> Source/WebCore/ChangeLog:3
> +        Web Inspector: refactor DefaultTextEditor

Please be more specific.

> Source/WebCore/ChangeLog:8
> +        Refactor DefaultTextEditor to separate its classes.

Please explain briefly what has changed and why.
Comment 3 Andrey Lushnikov 2012-12-28 08:42:41 PST
Created attachment 180878 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-29 01:20:49 PST
Comment on attachment 180878 [details]
Patch

Clearing flags on attachment: 180878

Committed r138560: <http://trac.webkit.org/changeset/138560>
Comment 5 WebKit Review Bot 2012-12-29 01:20:53 PST
All reviewed patches have been landed.  Closing bug.