Bug 105823

Summary:

Web Inspector: rename distanceToWindow to distance

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+, webkit.review.bot: commit-queue-

Yury Semikhatsky

Reported 2012-12-28 01:11:19 PST

Node distance in heap profiler is going to be a distance to the DOMWindow object in case of JS and a distance to root in case of native heap snapshot.

Attachments
Patch (22.71 KB, patch) 2012-12-28 01:14 PST, Yury Semikhatsky	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-12-28 01:14:19 PST

Created attachment 180855 [details] Patch

WebKit Review Bot

Comment 2 2012-12-28 01:24:10 PST

Comment on attachment 180855 [details] Patch Rejecting attachment 180855 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15546821

Yury Semikhatsky

Comment 3 2012-12-28 01:27:20 PST

Committed r138528: <http://trac.webkit.org/changeset/138528>

Note You need to log in before you can comment on or make changes to this bug.