Bug 105823 - Web Inspector: rename distanceToWindow to distance
Summary: Web Inspector: rename distanceToWindow to distance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-28 01:11 PST by Yury Semikhatsky
Modified: 2012-12-28 01:27 PST (History)
10 users (show)

See Also:

Attachments
Patch (22.71 KB, patch)
2012-12-28 01:14 PST, Yury Semikhatsky 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-12-28 01:11:19 PST 
Node distance in heap profiler is going to be a distance to the DOMWindow object in case of JS and a distance to root in case of native heap snapshot.
Comment 1 Yury Semikhatsky 2012-12-28 01:14:19 PST 
Created attachment 180855 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-28 01:24:10 PST 
Comment on attachment 180855 [details]
Patch

Rejecting attachment 180855 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15546821
Comment 3 Yury Semikhatsky 2012-12-28 01:27:20 PST 
Committed r138528: <http://trac.webkit.org/changeset/138528>