Bug 105822

Summary:

Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas

Product:

WebKit

Reporter:

Andrey Adaikin <aandrey>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Adaikin <aandrey>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Screenshot	none
Patch	none
Patch	pfeldman: review+, webkit.review.bot: commit-queue-

Andrey Adaikin

Reported 2012-12-28 01:11:17 PST

Patch to follow.

Attachments
Patch (5.38 KB, patch) 2012-12-28 01:12 PST, Andrey Adaikin	no flags	Details Formatted Diff Diff
Screenshot (651.58 KB, image/png) 2012-12-28 01:13 PST, Andrey Adaikin	no flags	Details
Patch (5.92 KB, patch) 2012-12-28 06:10 PST, Andrey Adaikin	no flags	Details Formatted Diff Diff
Patch (7.02 KB, patch) 2012-12-29 06:43 PST, Andrey Adaikin	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrey Adaikin

Comment 1 2012-12-28 01:12:59 PST

Created attachment 180853 [details] Patch

Andrey Adaikin

Comment 2 2012-12-28 01:13:49 PST

Created attachment 180854 [details] Screenshot

Pavel Feldman

Comment 3 2012-12-28 04:50:47 PST

Comment on attachment 180853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180853&action=review > Source/WebCore/inspector/front-end/CanvasProfileView.js:203 > + this._decorationElement = document.createElement("div"); You should only use css for styling.

Andrey Adaikin

Comment 4 2012-12-28 06:10:27 PST

Created attachment 180868 [details] Patch

Pavel Feldman

Comment 5 2012-12-29 04:40:14 PST

Comment on attachment 180868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180868&action=review > Source/WebCore/inspector/front-end/CanvasProfileView.js:205 > + this._decorationElement.style.display = "none"; "hidden" style class would do that for you. > Source/WebCore/inspector/front-end/CanvasProfileView.js:209 > + reloadPageButton.textContent = "Reload"; This should be localized > Source/WebCore/inspector/front-end/CanvasProfileView.js:298 > + this._decorationElement.style.display = showWarning ? "" : "none"; ditto

Andrey Adaikin

Comment 6 2012-12-29 06:43:29 PST

Created attachment 180936 [details] Patch

WebKit Review Bot

Comment 7 2012-12-29 07:28:28 PST

Comment on attachment 180936 [details] Patch Attachment 180936 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15582400 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

WebKit Review Bot

Comment 8 2013-01-10 22:52:47 PST

Comment on attachment 180936 [details] Patch Rejecting attachment 180936 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15801335

Andrey Adaikin

Comment 9 2013-01-10 22:58:43 PST

Committed r139408: <http://trac.webkit.org/changeset/139408>

Note You need to log in before you can comment on or make changes to this bug.