Bug 105809 – [Texmap] Use a transform uniform instead of u_flip/u_textureSize

• Component: New Bugs
• Status: RESOLVED FIXED

[Noam Rosenthal]

[Texmap] Use a transform uniform instead of u_flip/u_textureSize

[Noam Rosenthal]

Created attachment 180826 [details]
Patch

[Martin Robinson]

Comment on attachment 180826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180826&action=review

Looks good to me, but I  have a couple questions.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:505
> +        patternTransform.setM22(-1);

Why not patternTransform.flipY() ?

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:176
> +            // Clamp in the shader, we can't rely on the texture wrap mode to clamp.
> +            vec4 clampedPosition = clamp(vec4(position, 0., 1.), 0., 1.);

Hrm. I don't really understand this bit of code...

[Noam Rosenthal]

(In reply to comment #2)
> (From update of attachment 180826 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180826&action=review
> 
> Looks good to me, but I  have a couple questions.
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:505
> > +        patternTransform.setM22(-1);
> 
> Why not patternTransform.flipY() ?

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:176
> > +            // Clamp in the shader, we can't rely on the texture wrap mode to clamp.
> > +            vec4 clampedPosition = clamp(vec4(position, 0., 1.), 0., 1.);
> 
> Hrm. I don't really understand this bit of code...

[Noam Rosenthal]

Created attachment 180828 [details]
Patch

[Noam Rosenthal]

Created attachment 180912 [details]
Patch

[WebKit Review Bot]

Comment on attachment 180912 [details]
Patch

Clearing flags on attachment: 180912

Committed r138556: <http://trac.webkit.org/changeset/138556>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.