Summary: | [Texmap] Use a transform uniform instead of u_flip/u_textureSize | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||
Component: | New Bugs | Assignee: | Noam Rosenthal <noam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | jturcotte, kenneth, mrobinson, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 105377 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Noam Rosenthal
2012-12-27 15:20:38 PST
Created attachment 180826 [details]
Patch
Comment on attachment 180826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180826&action=review Looks good to me, but I have a couple questions. > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:505 > + patternTransform.setM22(-1); Why not patternTransform.flipY() ? > Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:176 > + // Clamp in the shader, we can't rely on the texture wrap mode to clamp. > + vec4 clampedPosition = clamp(vec4(position, 0., 1.), 0., 1.); Hrm. I don't really understand this bit of code... (In reply to comment #2) > (From update of attachment 180826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180826&action=review > > Looks good to me, but I have a couple questions. > > > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:505 > > + patternTransform.setM22(-1); > > Why not patternTransform.flipY() ? > > > Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp:176 > > + // Clamp in the shader, we can't rely on the texture wrap mode to clamp. > > + vec4 clampedPosition = clamp(vec4(position, 0., 1.), 0., 1.); > > Hrm. I don't really understand this bit of code... Created attachment 180828 [details]
Patch
Created attachment 180912 [details]
Patch
Comment on attachment 180912 [details] Patch Clearing flags on attachment: 180912 Committed r138556: <http://trac.webkit.org/changeset/138556> All reviewed patches have been landed. Closing bug. |