Bug 105800

Summary: Web Inspector: Native Memory Instrumentation. Update clang plugin according to current instrumentation state.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-12-27 06:47:16 PST
The code of plugin is out of sync with current state of MemoryInstrumentation code.
Attachments
Patch (3.18 KB, patch)
2012-12-27 06:49 PST, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-12-27 06:49:07 PST
Created attachment 180798 [details] Patch
Yury Semikhatsky
Comment 2 2012-12-27 06:54:35 PST
Comment on attachment 180798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180798&action=review > Tools/clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:201 > + " info.addRawBuffer(m_pointer, m_length);\n" You should also add m_length field.
Ilya Tikhonovsky
Comment 3 2012-12-28 01:50:43 PST
Committed r138530: <http://trac.webkit.org/changeset/138530>
Note You need to log in before you can comment on or make changes to this bug.