Bug 105798

Summary: Web Inspector: move js heap snapshot preprocessing to JSHeapSnapshot
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+, pfeldman: commit-queue+

Yury Semikhatsky
Reported 2012-12-27 05:17:21 PST
Methods like HeapSnapshot._markDetachedDOMTreeNodes should be moved to JSHeapSnapshot as they only make sense for JavaScript heap snapshots.
Attachments
Patch (41.28 KB, patch)
2012-12-27 06:52 PST, Yury Semikhatsky 		pfeldman: review+
pfeldman: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-12-27 06:52:41 PST
Created attachment 180799 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-12-27 06:57:06 PST
Comment on attachment 180799 [details] Patch lgtm
Yury Semikhatsky
Comment 3 2012-12-27 07:58:31 PST
Committed r138501: <http://trac.webkit.org/changeset/138501>
Note You need to log in before you can comment on or make changes to this bug.