Bug 105795

Summary: Web Inspector: [Network] Data grid header and content cells are misaligned.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 105739    
Attachments:
Description Flags
Screenshot, 3x zoom
none
Patch
none
Patch none

Eugene Klyuchnikov
Reported 2012-12-27 04:30:11 PST
Created attachment 180789 [details] Screenshot, 3x zoom Header and content tables have different width.
Attachments
Screenshot, 3x zoom (8.32 KB, image/png)
2012-12-27 04:30 PST, Eugene Klyuchnikov 		no flags
Details
Patch (2.96 KB, patch)
2012-12-27 04:33 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (3.52 KB, patch)
2012-12-29 03:37 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-12-27 04:33:44 PST
Created attachment 180790 [details] Patch
Pavel Feldman
Comment 2 2012-12-28 02:54:02 PST
Comment on attachment 180790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review > Source/WebCore/ChangeLog:8 > + Header and content tables have different width -> same percent values Why is this happening?
Pavel Feldman
Comment 3 2012-12-28 02:57:26 PST
Comment on attachment 180790 [details] Patch This was used for scroller.
Eugene Klyuchnikov
Comment 4 2012-12-28 23:46:25 PST
(In reply to comment #3) > (From update of attachment 180790 [details]) > This was used for scroller. Scroller is still there thanks to "overflow-y: overlay;" style.
Andrey Adaikin
Comment 5 2012-12-29 03:26:39 PST
Comment on attachment 180790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review > Source/WebCore/inspector/front-end/DataGrid.js:137 > + fillerRow.appendChild(cell); instead of these 3 lines use: fillerRow.createChild("td", "corner"); > Source/WebCore/inspector/front-end/DataGrid.js:1077 > + this._element.appendChild(cell); ditto
Eugene Klyuchnikov
Comment 6 2012-12-29 03:36:22 PST
Comment on attachment 180790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review >> Source/WebCore/ChangeLog:8 >> + Header and content tables have different width -> same percent values > > Why is this happening? It was a hack to reserve place for scroller. >> Source/WebCore/inspector/front-end/DataGrid.js:137 >> + fillerRow.appendChild(cell); > > instead of these 3 lines use: > fillerRow.createChild("td", "corner"); Done. Thanks. >> Source/WebCore/inspector/front-end/DataGrid.js:1077 >> + this._element.appendChild(cell); > > ditto Done.
Eugene Klyuchnikov
Comment 7 2012-12-29 03:37:25 PST
Created attachment 180931 [details] Patch
WebKit Review Bot
Comment 8 2013-01-09 22:30:08 PST
Comment on attachment 180931 [details] Patch Clearing flags on attachment: 180931 Committed r139283: <http://trac.webkit.org/changeset/139283>
WebKit Review Bot
Comment 9 2013-01-09 22:30:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.