| Summary: | Web Inspector: [Network] Data grid header and content cells are misaligned. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eugene Klyuchnikov <eustas> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Eugene Klyuchnikov <eustas> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 105739 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 180790 [details]
Patch
Comment on attachment 180790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review > Source/WebCore/ChangeLog:8 > + Header and content tables have different width -> same percent values Why is this happening? Comment on attachment 180790 [details]
Patch
This was used for scroller.
(In reply to comment #3) > (From update of attachment 180790 [details]) > This was used for scroller. Scroller is still there thanks to "overflow-y: overlay;" style. Comment on attachment 180790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review > Source/WebCore/inspector/front-end/DataGrid.js:137 > + fillerRow.appendChild(cell); instead of these 3 lines use: fillerRow.createChild("td", "corner"); > Source/WebCore/inspector/front-end/DataGrid.js:1077 > + this._element.appendChild(cell); ditto Comment on attachment 180790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180790&action=review >> Source/WebCore/ChangeLog:8 >> + Header and content tables have different width -> same percent values > > Why is this happening? It was a hack to reserve place for scroller. >> Source/WebCore/inspector/front-end/DataGrid.js:137 >> + fillerRow.appendChild(cell); > > instead of these 3 lines use: > fillerRow.createChild("td", "corner"); Done. Thanks. >> Source/WebCore/inspector/front-end/DataGrid.js:1077 >> + this._element.appendChild(cell); > > ditto Done. Created attachment 180931 [details]
Patch
Comment on attachment 180931 [details] Patch Clearing flags on attachment: 180931 Committed r139283: <http://trac.webkit.org/changeset/139283> All reviewed patches have been landed. Closing bug. |
Created attachment 180789 [details] Screenshot, 3x zoom Header and content tables have different width.