Bug 105782

Summary: [TexMap] Minor refactoring of TextureMapperLayer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dongseong Hwang
Reported 2012-12-26 17:53:12 PST
This patch has two refactorings. 1. Replace TextureMapperPaintOptions from header to implementation file. 2. Add non copyable property to TextureMapperLayer.
Attachments
Patch (3.07 KB, patch)
2012-12-26 17:54 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-12-26 17:54:40 PST
Created attachment 180771 [details] Patch
Darin Adler
Comment 2 2012-12-27 09:51:56 PST
Comment on attachment 180771 [details] Patch OK
WebKit Review Bot
Comment 3 2012-12-27 09:58:16 PST
Comment on attachment 180771 [details] Patch Clearing flags on attachment: 180771 Committed r138508: <http://trac.webkit.org/changeset/138508>
WebKit Review Bot
Comment 4 2012-12-27 09:58:19 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2012-12-27 10:08:43 PST
One minor quibble. Marking a class as noncopyable is not a “refactoring” although it’s a sensible change to make here.
Dongseong Hwang
Comment 6 2012-12-27 18:19:53 PST
(In reply to comment #5) > One minor quibble. Marking a class as noncopyable is not a “refactoring” although it’s a sensible change to make here. aha, you are right. I'll use more sensible word in next time :)
Note You need to log in before you can comment on or make changes to this bug.