Bug 105763 – Web Inspector: prepare HeapSnapshot.js for use with native heap snapshot

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Yury Semikhatsky]

There are some implicit assumptions about the root node position etc which can be fixed to make HeapSnapshot.js more useful for native snapshots.

[Yury Semikhatsky]

Created attachment 180739 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 180739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180739&action=review

otherwise lgtm

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1343
> +        for (var nodeOrdinal = 0, l = this.nodeCount; nodeOrdinal < l; ++nodeOrdinal) {
> +            if (nodeOrdinal === rootNodeOrdinal)

Please use the same logic here. We don't need additional if statement inside.

[Yury Semikhatsky]

Created attachment 180740 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> Please use the same logic here. We don't need additional if statement inside.

Done.

[Alexander Pavlov (apavlov)]

Comment on attachment 180740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180740&action=review

> Source/WebCore/ChangeLog:8
> +        HeapSnapshot.js now expects root node to be either the first or the last(real) one

space between "last" and "(real)"?

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 180740 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180740&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        HeapSnapshot.js now expects root node to be either the first or the last(real) one
> 
> space between "last" and "(real)"?

Done.

[Yury Semikhatsky]

Committed r138475: <http://trac.webkit.org/changeset/138475>