Bug 105753

Summary: [CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos, paroga, rakuco, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-12-25 22:05:19 PST
CMakeLists.txt includes header files in source list. CMake doesn't need to include them.
Attachments
Patch (1.32 KB, patch)
2012-12-25 22:08 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2012-12-25 22:50 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-12-25 22:08:28 PST
Created attachment 180727 [details] Patch
Gyuyoung Kim
Comment 2 2012-12-25 22:10:01 PST
CC'ing Laszlo, Patrick and Yong.
Laszlo Gombos
Comment 3 2012-12-25 22:20:11 PST
Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ?
Gyuyoung Kim
Comment 4 2012-12-25 22:50:31 PST
Created attachment 180730 [details] Patch
Gyuyoung Kim
Comment 5 2012-12-25 22:51:13 PST
(In reply to comment #3) > Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ? Ah, I missed some header files. Patch is updated.
Laszlo Gombos
Comment 6 2012-12-25 23:11:27 PST
Comment on attachment 180730 [details] Patch r=me.
WebKit Review Bot
Comment 7 2012-12-25 23:25:57 PST
Comment on attachment 180730 [details] Patch Clearing flags on attachment: 180730 Committed r138472: <http://trac.webkit.org/changeset/138472>
WebKit Review Bot
Comment 8 2012-12-25 23:26:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.