Bug 105753

Summary: [CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos, paroga, rakuco, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Gyuyoung Kim 2012-12-25 22:05:19 PST 
CMakeLists.txt includes header files in source list. CMake doesn't need to include them.
Comment 1 Gyuyoung Kim 2012-12-25 22:08:28 PST 
Created attachment 180727 [details]
Patch
Comment 2 Gyuyoung Kim 2012-12-25 22:10:01 PST 
CC'ing Laszlo, Patrick and Yong.
Comment 3 Laszlo Gombos 2012-12-25 22:20:11 PST 
Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ?
Comment 4 Gyuyoung Kim 2012-12-25 22:50:31 PST 
Created attachment 180730 [details]
Patch
Comment 5 Gyuyoung Kim 2012-12-25 22:51:13 PST 
(In reply to comment #3)
> Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ?

Ah, I missed some header files. Patch is updated.
Comment 6 Laszlo Gombos 2012-12-25 23:11:27 PST 
Comment on attachment 180730 [details]
Patch

r=me.
Comment 7 WebKit Review Bot 2012-12-25 23:25:57 PST 
Comment on attachment 180730 [details]
Patch

Clearing flags on attachment: 180730

Committed r138472: <http://trac.webkit.org/changeset/138472>
Comment 8 WebKit Review Bot 2012-12-25 23:26:02 PST 
All reviewed patches have been landed.  Closing bug.