Bug 105743

Summary: [GObject bindings] Wrap event target interface code in feature define guards if necessary
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, jdapena, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch xan.lopez: review+

Zan Dobersek
Reported 2012-12-25 10:25:05 PST
Like other binding method implementations, the event target interface code should be guarded by the feature define guards if present. This problem currently shows when building WebKitGTK+ with video track feature disabled.
Attachments
Patch (7.23 KB, patch)
2012-12-25 10:35 PST, Zan Dobersek 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-12-25 10:35:47 PST
Created attachment 180714 [details] Patch
Xan Lopez
Comment 2 2013-01-04 02:02:47 PST
Looks sane. No need to update the bindings tests after this?
Zan Dobersek
Comment 3 2013-01-04 02:53:28 PST
(In reply to comment #2) > Looks sane. No need to update the bindings tests after this? No, no tests are affected. I guess no event target behind a conditional is present in the bindings tests.
Xan Lopez
Comment 4 2013-01-04 04:07:55 PST
Comment on attachment 180714 [details] Patch OK, let's do it.
Zan Dobersek
Comment 5 2013-01-04 06:14:38 PST
Committed r138793: <http://trac.webkit.org/changeset/138793>
Zan Dobersek
Comment 6 2013-05-07 01:45:52 PDT
*** Bug 95937 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.