Bug 105743

Summary:

[GObject bindings] Wrap event target interface code in feature define guards if necessary

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

WebKitGTK

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, jdapena, webkit.review.bot, xan.lopez

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	xan.lopez: review+

Description Zan Dobersek 2012-12-25 10:25:05 PST

Like other binding method implementations, the event target interface code should be guarded by the feature define guards if present.

This problem currently shows when building WebKitGTK+ with video track feature disabled.

Comment 1 Zan Dobersek 2012-12-25 10:35:47 PST

Created attachment 180714 [details]
Patch

Comment 2 Xan Lopez 2013-01-04 02:02:47 PST

Looks sane. No need to update the bindings tests after this?

Comment 3 Zan Dobersek 2013-01-04 02:53:28 PST

(In reply to comment #2)
> Looks sane. No need to update the bindings tests after this?

No, no tests are affected. I guess no event target behind a conditional is present in the bindings tests.

Comment 4 Xan Lopez 2013-01-04 04:07:55 PST

Comment on attachment 180714 [details]
Patch

OK, let's do it.

Comment 5 Zan Dobersek 2013-01-04 06:14:38 PST

Committed r138793: <http://trac.webkit.org/changeset/138793>

Comment 6 Zan Dobersek 2013-05-07 01:45:52 PDT

*** Bug 95937 has been marked as a duplicate of this bug. ***