| Summary: | Make the override-feature-defines script compatible with Python v3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mrobinson | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2012-12-25 10:20:18 PST
Created attachment 180713 [details]
Patch
Comment on attachment 180713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180713&action=review > Tools/gtk/override-feature-defines:33 > + print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines))) Has the % operator been removed from py3? (In reply to comment #2) > (From update of attachment 180713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180713&action=review > > > Tools/gtk/override-feature-defines:33 > > + print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines))) > > Has the % operator been removed from py3? Not yet, but there were plans to deprecate and eventually remove it[1]. The plans might have changed since then, though[2]. The Advances String Formatting[3], supported since Python 2.6, is recommended (especially in Python 3). [1] http://docs.python.org/release/3.2.3/whatsnew/3.0.html#pep-3101-a-new-approach-to-string-formatting [2] http://www.mail-archive.com/django-developers@googlegroups.com/msg35057.html [3] http://www.python.org/dev/peps/pep-3101/ Comment on attachment 180713 [details] Patch Clearing flags on attachment: 180713 Committed r139065: <http://trac.webkit.org/changeset/139065> All reviewed patches have been landed. Closing bug. |