Summary: | [BlackBerry] Update BB10 media render theme. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tiancheng Jiang <tijiang> | ||||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cmarcelo, dglazkov, eric.carlson, feature-media-reviews, jgriggs, macpherson, menard, mifenton, ojan.autocc, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Tiancheng Jiang
2012-12-24 10:40:48 PST
Created attachment 180684 [details]
Patch
Comment on attachment 180684 [details]
Patch
LGTM.
Comment on attachment 180684 [details] Patch Clearing flags on attachment: 180684 Committed r138447: <http://trac.webkit.org/changeset/138447> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 181059 [details]
Patch
Comment on attachment 181059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1094 > + static Image* mediaSliderThumb; > + if (!isEnabled(object)) > + mediaSliderThumb = Image::loadPlatformResource("core_slider_handle_disabled").leakRef(); > + else { > + if (isPressed(object) || isHovered(object) || isFocused(object)) > + mediaSliderThumb = Image::loadPlatformResource("core_slider_handle_pressed").leakRef(); > + else > + mediaSliderThumb = Image::loadPlatformResource("core_media_handle").leakRef(); > + } will this leak an image every time? I would use 3 static Image* objects that are initialized upon first time, and then reused. Comment on attachment 181059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181059&action=review > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1135 > + static Image* volumeBar = Image::loadPlatformResource("core_slider_played_bg").leakRef(); > + // This is to paint main volume slider bar. A space between 1134 and 1135 would be neat. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1140 > + bool result = paintSliderTrackRect(object, paintInfo, rect2, volumeBackground); > + > + if (volume > 0) { > + // This is to paint volume bar (left of volume slider thumb) using selection color. > + paintSliderTrackRect(object, paintInfo, volumeRect, volumeBar); I'm confused here. should it be result |= paintSliderTrackRect(object, paintInfo, volumeRect, volumeBar); Created attachment 181075 [details]
Patch
Comment on attachment 181075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181075&action=review LGTM. But it doesn't apply to webkit ToT? You may want John to review it again. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1089 > static Image* mediaSliderThumb = Image::loadPlatformResource("core_media_handle").leakRef(); > - > + if (!isEnabled(object)) minor: a space here would be nice. Comment on attachment 181075 [details]
Patch
Looks good to me
R+ from me as well. Created attachment 181176 [details]
Patch
Comment on attachment 181176 [details] Patch Rejecting attachment 181176 [details] from commit-queue. tijiang@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 181176 [details] Patch Attachment 181176 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15647746 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Comment on attachment 181176 [details] Patch Clearing flags on attachment: 181176 Committed r138712: <http://trac.webkit.org/changeset/138712> All reviewed patches have been landed. Closing bug. |