Bug 105703

Summary: Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: gtk-ews, hausmann, jturcotte, mitz, ossy, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Sam Weinig
Reported 2012-12-23 19:31:28 PST
Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection
Attachments
Patch (16.91 KB, patch)
2012-12-23 19:37 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (18.66 KB, patch)
2012-12-23 20:10 PST, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-12-23 19:37:52 PST
Created attachment 180634 [details] Patch
WebKit Review Bot
Comment 2 2012-12-23 19:40:48 PST
Attachment 180634 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/Cookies/WebCookieManager.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-12-23 19:45:00 PST
Comment on attachment 180634 [details] Patch Attachment 180634 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15508264
Early Warning System Bot
Comment 4 2012-12-23 19:45:43 PST
Comment on attachment 180634 [details] Patch Attachment 180634 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15503265
EFL EWS Bot
Comment 5 2012-12-23 19:49:26 PST
Comment on attachment 180634 [details] Patch Attachment 180634 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15498296
kov's GTK+ EWS bot
Comment 6 2012-12-23 19:56:20 PST
Comment on attachment 180634 [details] Patch Attachment 180634 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15498298
Sam Weinig
Comment 7 2012-12-23 20:10:18 PST
Created attachment 180638 [details] Patch
Sam Weinig
Comment 8 2012-12-23 21:46:05 PST
Committed r138433: <http://trac.webkit.org/changeset/138433>
Csaba Osztrogonác
Comment 9 2012-12-24 00:17:15 PST
(In reply to comment #8) > Committed r138433: <http://trac.webkit.org/changeset/138433> It broke the Qt-Windows build: c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(53) : error C2061: syntax error : identifier 'uint64_t' c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(58) : error C2061: syntax error : identifier 'uint64_t' C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\WebProcess\Cookies\WebCookieManager.cpp(61) : error C2511: 'void WebKit::WebCookieManager::getHostnamesWithCookies(uint64_t)' : overloaded member function not found in 'WebKit::WebCookieManager' c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(42) : see declaration of 'WebKit::WebCookieManager' C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\WebProcess\Cookies\WebCookieManager.cpp(108) : error C2511: 'void WebKit::WebCookieManager::getHTTPCookieAcceptPolicy(uint64_t)' : overloaded member function not found in 'WebKit::WebCookieManager' c:\webkitbuildslave\szeged-windows-1\qt-windows-32bit-release\build\source\webkit2\webprocess\cookies\WebCookieManager.h(42) : see declaration of 'WebKit::WebCookieManager'
Csaba Osztrogonác
Comment 10 2012-12-24 00:21:04 PST
Speculative buildfix landed in https://trac.webkit.org/changeset/138435.
Note You need to log in before you can comment on or make changes to this bug.