Summary: | JITThunks should not compile only because of luck | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||||||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
Severity: | Normal | CC: | barraclough, benjamin, buildbot, cdumez, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, ojan.autocc, oliver, ossy, philn, rakuco, rniwa, sam, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||||
Bug Depends on: | 105744 | ||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||
Attachments: |
|
Description
Filip Pizlo
2012-12-23 12:28:52 PST
Created attachment 180628 [details]
the patch
This will probably still have random build errors. I'm still checking if I need to add #include Operations.h into WebCore and elsewhere.
Comment on attachment 180628 [details]
the patch
rs=me
Attachment 180628 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:337: The parameter name "plan" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:338: The parameter name "plan" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 56 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180628 [details] the patch Attachment 180628 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15492228 Comment on attachment 180628 [details] the patch Attachment 180628 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15492224 Comment on attachment 180628 [details] the patch Attachment 180628 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15513025 Created attachment 180629 [details]
another attempt
I think I still have a lot of work to do adding #include "Operations.h" in WebCore.
Created attachment 180641 [details]
patch for landing
Hopefully this will make all of the things happy.
Attachment 180641 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/RegExpCachedResult.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/SmallStrings.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 164 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180641 [details] patch for landing Attachment 180641 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15503295 Comment on attachment 180641 [details] patch for landing Attachment 180641 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15498328 Comment on attachment 180641 [details] patch for landing Attachment 180641 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15511197 Created attachment 180679 [details]
patch for landing
Try to fix Qt build. Hopefully it also fixes EFL build.
Attachment 180679 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/RegExpCachedResult.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/SmallStrings.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 165 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180679 [details] patch for landing Attachment 180679 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15507533 Comment on attachment 180679 [details] patch for landing Attachment 180679 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15512476 Created attachment 180685 [details]
patch for landing
Attachment 180685 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 166 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180685 [details] patch for landing Attachment 180685 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15491629 Created attachment 180689 [details]
patch for landing
And try again.
Attachment 180689 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 178 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180689 [details] patch for landing Attachment 180689 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15492607 Created attachment 180690 [details]
patch for landing
Trying again.
Attachment 180690 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 184 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180690 [details] patch for landing Attachment 180690 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15527125 Created attachment 180691 [details]
trying to touch Platform.h
Trying to see if the build error is due to EFL's build system not doing dependencies correctly.
Attachment 180691 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 185 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180691 [details] trying to touch Platform.h Attachment 180691 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15495588 Comment on attachment 180691 [details] trying to touch Platform.h Attachment 180691 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15496609 Comment on attachment 180691 [details] trying to touch Platform.h Attachment 180691 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15490715 Created attachment 180696 [details]
trying more things
Attachment 180696 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 186 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 180696 [details] trying more things Attachment 180696 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15497652 Comment on attachment 180696 [details] trying more things Attachment 180696 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15496679 Comment on attachment 180696 [details] trying more things Attachment 180696 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15492693 FYI, the patch is building just fine on my machine for EFL port (despite the EWS saying otherwise). It probably just requires a clean build? (In reply to comment #36) > FYI, the patch is building just fine on my machine for EFL port (despite the EWS saying otherwise). It probably just requires a clean build? Hmm, there are still linking errors on my PC though I build this patch from scratch. Linking CXX executable ../../../bin/jsc ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::isGetterSetter() const' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::JSValue(JSC::JSCell*)' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::asCell() const' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSValue::decode(long)' ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `JSC::JSCell::structure() const' collect2: ld returned 1 exit status make[2]: *** [bin/jsc] Error 1 make[1]: *** [Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/all] Error 2 (In reply to comment #34) > (From update of attachment 180696 [details]) > Attachment 180696 [details] did not pass qt-wk2-ews (qt): > Output: http://queues.webkit.org/results/15496679 There are many conflicts and I can't apply the patch on ToT: Source/JavaScriptCore/CMakeLists.txt Source/JavaScriptCore/GNUmakefile.list.am Source/JavaScriptCore/Target.pri Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj Source/JavaScriptCore/jit/JITStubs.cpp Let's see an earlier revision - r138446. The build failed for me as the EWS said. I tracked down in which objects are these missing symbols an then I added #include "Operations.h" to the following files and now Qt build is happy on r138446: - ErrorInstance.cpp - NameInstance.cpp - JSVariableObject.cpp Comment on attachment 180628 [details] the patch Cleared Sam Weinig's review+ from obsolete attachment 180628 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 182210 [details]
patch for landing
Attachment 182210 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 178 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15806116 Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15809079 Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15806117 Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15775910 Attachment 182210 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 178 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15795388 Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15811051 Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15803142 Comment on attachment 182210 [details] patch for landing Attachment 182210 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15805138 Created attachment 182406 [details]
patch for landing
Attachment 182406 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1
Source/JavaScriptCore/runtime/NumberConstructor.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 181 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed in http://trac.webkit.org/changeset/139541 Fixed changelogs in http://trac.webkit.org/changeset/139542 (In reply to comment #53) > Landed in http://trac.webkit.org/changeset/139541 After this one https://trac.webkit.org/changeset/141185/trunk/Source/JavaScriptCore/runtime/JSGlobalData.h fixed the !ENABLE_JIT build. (In reply to comment #53) > Landed in http://trac.webkit.org/changeset/139541 One more buildfix for !ENABLE(JIT) case - http://trac.webkit.org/changeset/142489 |