Bug 105687

Summary: [EFL][WK2] Refactor snapshot taking code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103468    
Attachments:
Description Flags
Patch
none
Patch
kenneth: review+, webkit.review.bot: commit-queue-
Patch for landing none

Chris Dumez
Reported 2012-12-23 06:31:07 PST
We should rename WKViewGetSnapshot to WKViewCreateSnapshot since the returned value needs to be adopted. The snapshot taking code should also be refactored to use smart pointers when possible.
Attachments
Patch (8.56 KB, patch)
2012-12-23 06:40 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.78 KB, patch)
2012-12-24 04:59 PST, Chris Dumez 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (8.73 KB, patch)
2012-12-25 03:57 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-12-23 06:40:23 PST
Created attachment 180619 [details] Patch
Chris Dumez
Comment 2 2012-12-23 13:04:50 PST
Comment on attachment 180619 [details] Patch I think we can simplify a bit more, clearing flags for now.
Chris Dumez
Comment 3 2012-12-24 04:24:48 PST
(In reply to comment #2) > (From update of attachment 180619 [details]) > I think we can simplify a bit more, clearing flags for now. Nevermind, I think this is good enough for now. The patch is ready for review.
Chris Dumez
Comment 4 2012-12-24 04:41:19 PST
Comment on attachment 180619 [details] Patch Actually, we can remove the call to glBindTexture() before glReadPixels(). It is not needed as glReadPixels() reads from the frame buffer, not the texture.
Chris Dumez
Comment 5 2012-12-24 04:59:10 PST
Created attachment 180663 [details] Patch
Kenneth Rohde Christiansen
Comment 6 2012-12-25 03:29:19 PST
Comment on attachment 180663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180663&action=review > Source/WebKit2/ChangeLog:21 > + a cairo_surface_t instead of a WKType. The value should be > + converted to a WKType a C API level. at*
WebKit Review Bot
Comment 7 2012-12-25 03:31:33 PST
Comment on attachment 180663 [details] Patch Rejecting attachment 180663 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue ChangeLog entry in Tools/ChangeLog is not at the top of the file. Full output: http://queues.webkit.org/results/15503681
Chris Dumez
Comment 8 2012-12-25 03:57:21 PST
Created attachment 180706 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-12-25 04:29:43 PST
Comment on attachment 180706 [details] Patch for landing Clearing flags on attachment: 180706 Committed r138462: <http://trac.webkit.org/changeset/138462>
WebKit Review Bot
Comment 10 2012-12-25 04:29:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.