Bug 105677

Summary: [EFL [WebGL] GLES2 detection is broken.
Product: WebKit Reporter: Kalyan <kalyan.kondapally>
Component: WebKit EFLAssignee: Kalyan <kalyan.kondapally>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 105659    
Attachments:
Description Flags
patch none

Kalyan
Reported 2012-12-22 04:46:25 PST
We use the logic in FindGLES.cmake to detect GLES2 support during compile time. OPENGLES2_FOUND is never set, even though OPENGLES2_INCLUDE_DIR and OPENGLES2_LIBRARY contain right information. The name passed to find_package_handle_standard_args seems to be the issue here. GLES2 should be changed OPENGLES2. Will update a patch with the correction.
Attachments
patch (1.41 KB, patch)
2012-12-22 05:36 PST, Kalyan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kalyan
Comment 1 2012-12-22 05:36:48 PST
Created attachment 180603 [details] patch
Kenneth Rohde Christiansen
Comment 2 2012-12-24 01:57:25 PST
Comment on attachment 180603 [details] patch Looks ok to me, but I have to trust you on this one
WebKit Review Bot
Comment 3 2012-12-24 02:04:49 PST
Comment on attachment 180603 [details] patch Clearing flags on attachment: 180603 Committed r138437: <http://trac.webkit.org/changeset/138437>
WebKit Review Bot
Comment 4 2012-12-24 02:04:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.