Bug 105669

Summary: instance-of-immediates.js : the word "passing" is spelled incorrectly
Product: WebKit Reporter: Stuart Eichert <stuart-webkit>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, helder.correia, jchaffraix, luiz, michelangelo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Stuart Eichert
Reported 2012-12-21 16:19:11 PST
The comments in instance-of-immediates.js describe what is being passed to the test function, testSet. The word "passsing" should be spelled "passing".
Attachments
patch (4.11 KB, patch)
2012-12-21 16:46 PST, Stuart Eichert 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stuart Eichert
Comment 1 2012-12-21 16:46:56 PST
Created attachment 180574 [details] patch
Michelangelo De Simone
Comment 2 2012-12-22 03:51:07 PST
LGTM, I guess it would make total sense to ask for r? and cq?. Let's see who can take care of this.
Julien Chaffraix
Comment 3 2012-12-22 09:07:32 PST
(In reply to comment #2) > LGTM, I guess it would make total sense to ask for r? and cq?. The change makes sense. Stuart are you posting this patch for review? BTW we really welcome spelling fixes but we usually prefer such massaging to occur as part of some other change (this is our policy for fixing style violations and extra white spaces). The rationale is to avoid unneeded churn when blaming the files.
Stuart Eichert
Comment 4 2012-12-22 12:24:56 PST
(In reply to comment #3) > (In reply to comment #2) > > LGTM, I guess it would make total sense to ask for r? and cq?. > > The change makes sense. Stuart are you posting this patch for review? > > BTW we really welcome spelling fixes but we usually prefer such massaging to occur as part of some other change (this is our policy for fixing style violations and extra white spaces). The rationale is to avoid unneeded churn when blaming the files. Yes, I am posting this patch for review. Thanks for the note about fixing spelling, style, etc. during the course of some other change. I'll try to do that in the future.
Julien Chaffraix
Comment 5 2012-12-27 23:59:07 PST
Comment on attachment 180574 [details] patch Great, patches for review should have the r? flag set in the future.
WebKit Review Bot
Comment 6 2012-12-28 00:02:11 PST
Comment on attachment 180574 [details] patch Clearing flags on attachment: 180574 Committed r138524: <http://trac.webkit.org/changeset/138524>
WebKit Review Bot
Comment 7 2012-12-28 00:02:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.