Bug 105662

Summary: CMakeChecker takes unusually long time to run
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Halton Huo <halton.huo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, dpranke, eric, glenn, halton.huo, laszlo.gombos, paroga, rafael.lobo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121764    
Bug Blocks:    
Attachments:
Description Flags
Patch rniwa: review+

WebKit Review Bot
Reported 2012-12-21 14:53:27 PST
CMakeChecker takes unusually long time to run Requested by dglazkov on #webkit.
Attachments
Patch (11.17 KB, patch)
2013-09-25 10:31 PDT, Patrick R. Gansterer 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2012-12-21 14:55:25 PST
Not sure why, but when I modify CMakeLists, the check-webkit-style sits there for seconds. It's a beefy machine. It shouldn't do that.
Laszlo Gombos
Comment 2 2013-01-28 09:58:43 PST
Related commit - http://trac.webkit.org/changeset/137057 .
Rafael Brandao
Comment 3 2013-02-08 16:46:14 PST
I've experienced this when doing this patch: https://bugs.webkit.org/attachment.cgi?id=187386&action=review
Patrick R. Gansterer
Comment 4 2013-09-23 01:44:14 PDT
The problem is that a bunch of regualr expressions is compiled for every line. Caching them (like we do in the cpp checker fixes it). This is done in bug 121764.
Patrick R. Gansterer
Comment 5 2013-09-25 10:31:04 PDT
Created attachment 212595 [details] Patch
Ryosuke Niwa
Comment 6 2013-09-25 10:32:18 PDT
Comment on attachment 212595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212595&action=review > Tools/Scripts/webkitpy/style/checkers/common.py:46 > + """Matches the string with the pattern, caching the compiled regexp.""" These comments are pretty useless.
Patrick R. Gansterer
Comment 7 2013-09-25 10:39:29 PDT
Committed r156403: <http://trac.webkit.org/changeset/156403>
Note You need to log in before you can comment on or make changes to this bug.