Bug 105651

Summary: Invalid assert in GeolocationClientBlackBerry.cpp
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: WebKit BlackBerryAssignee: Joe Mason <joenotcharles>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
fix none

Joe Mason
Reported 2012-12-21 12:40:22 PST
GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is in m_geolocationRequestMap. But it's perfectly valid for the location to not be in the map - for instance, if GeolocationClientBlackBerry::requestPermission returned immediately, without putting it in the map, because geolocation was disabled. In this case the correct thing to do is just return - there is nothing to be done to cancel the permission.
Attachments
fix (2.89 KB, patch)
2012-12-21 13:21 PST, Joe Mason 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joe Mason
Comment 1 2012-12-21 13:21:18 PST
Created attachment 180547 [details] fix
WebKit Review Bot
Comment 2 2013-01-16 14:32:43 PST
Comment on attachment 180547 [details] fix Clearing flags on attachment: 180547 Committed r139925: <http://trac.webkit.org/changeset/139925>
WebKit Review Bot
Comment 3 2013-01-16 14:32:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.