Bug 105576

Summary: JIT: Change uninitialized pointer value -1 to constant
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2012-12-20 14:03:21 PST
The various JIT engines use -1 (0xff....ff depending on pointer size) for a pointer that doesn't point to anything valid. The value of -1 is just used directly in the code. This should be changed in two ways. 1) We should use a symbolic constant so the source code is clearer in what we are doing. 2) The value of -1 isn't a good value, because it is negative and doesn't aid in debugging.
Attachments
Patch (17.93 KB, patch)
2012-12-20 14:48 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-12-20 14:48:41 PST
Created attachment 180415 [details] Patch
WebKit Review Bot
Comment 2 2012-12-20 15:21:40 PST
Comment on attachment 180415 [details] Patch Clearing flags on attachment: 180415 Committed r138308: <http://trac.webkit.org/changeset/138308>
WebKit Review Bot
Comment 3 2012-12-20 15:21:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.