Bug 105565

Summary: fastAttributeLookupAllowed: classAttr is only animatable by SVG styled elements
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: New BugsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, d-r, eric, fmalita, haraken, japhet, kling, koivisto, krit, ojan.autocc, pdr, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Erik Arvidsson
Reported 2012-12-20 12:23:47 PST
Only consider styled SVG elements for fastAttributeLookupAllowed
Attachments
Patch (3.18 KB, patch)
2012-12-20 12:26 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Patch (5.18 KB, patch)
2012-12-20 12:59 PST, Erik Arvidsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2012-12-20 12:26:36 PST
Created attachment 180386 [details] Patch
Erik Arvidsson
Comment 2 2012-12-20 12:55:21 PST
A have a more correct patch coming in a sec
Erik Arvidsson
Comment 3 2012-12-20 12:59:06 PST
Created attachment 180393 [details] Patch
Eric Seidel (no email)
Comment 4 2012-12-20 13:06:14 PST
Comment on attachment 180393 [details] Patch Looks reasonable to me. I've cc'd antti/kling who are the real experts for the fastAttr stuff.
Andreas Kling
Comment 5 2012-12-20 13:09:56 PST
(In reply to comment #4) > (From update of attachment 180393 [details]) > Looks reasonable to me. I've cc'd antti/kling who are the real experts for the fastAttr stuff. LGTM!
Philip Rogers
Comment 6 2012-12-20 13:10:30 PST
(In reply to comment #4) > (From update of attachment 180393 [details]) > Looks reasonable to me. I've cc'd antti/kling who are the real experts for the fastAttr stuff. This also seems reasonable to me. I went through all the animatable elements with the class attribute and it looks like you're covered (seriously, <desc> is stylable?)
Philip Rogers
Comment 7 2012-12-20 13:14:53 PST
(In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 180393 [details] [details]) > > Looks reasonable to me. I've cc'd antti/kling who are the real experts for the fastAttr stuff. > > This also seems reasonable to me. I went through all the animatable elements with the class attribute and it looks like you're covered (seriously, <desc> is stylable?) It looks like the good folks working on SVG2 have fixed this so we will be able to remove the special if check in the future: https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement
WebKit Review Bot
Comment 8 2012-12-20 13:41:22 PST
Comment on attachment 180393 [details] Patch Clearing flags on attachment: 180393 Committed r138296: <http://trac.webkit.org/changeset/138296>
WebKit Review Bot
Comment 9 2012-12-20 13:41:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.