Bug 105564 – [GTK] Remove plugin process configuration option

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Martin Robinson]

Instead of allowing building without the WebKit2 plugin process, it should always be built for the GTK+ port.

[Martin Robinson]

Created attachment 180387 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 180387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180387&action=review

This will automatically fix bug #89451. Thanks!

> Source/WebKit2/ChangeLog:13
> +

I think in-process plugin process is indeed incompatible in GTK+, because WebKit2 depends on GTK+ 3 and plugin process requires GTK+ 2 to work. When built in-process it would use GTK+ 3 and some plugins like flash won't work. You might want to mention it in the ChangeLog to make it clear we are not removing it just for the sake of reducing the configuration options.

[Carlos Garcia Campos]

Comment on attachment 180387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180387&action=review

Something happened in my browser and last comment was not included in the comment

> configure.ac:1089
>     PKG_CHECK_MODULES(GTK2, gtk+-2.0 >= $GTK2_REQUIRED_VERSION gail >= $GAIL2_REQUIRED_VERSION)

Instead of checking again here if we are building webkit2, you could just move this above to the previous if test "$enable_webkit2" = "yes" block and check if gtk2 is present before unix printing.

[Martin Robinson]

Committed r138425: <http://trac.webkit.org/changeset/138425>