Bug 105522

Summary: REGRESSION (r138184): transitions/transitions-parsing.html is failing on GTK
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot, xan.lopez, zan
Priority: P2 Keywords: Gtk, LayoutTestFailure, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-12-20 02:58:29 PST
The transitions/transitions-parsing.html layout test is failing since r138184 landed. http://trac.webkit.org/changeset/138184 Diff too large, so just trust me! :>
Attachments
Patch (5.85 KB, patch)
2012-12-26 08:11 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-12-26 08:11:18 PST
Created attachment 180748 [details] Patch
WebKit Review Bot
Comment 2 2012-12-26 08:56:54 PST
Comment on attachment 180748 [details] Patch Attachment 180748 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15542218 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Zan Dobersek
Comment 3 2012-12-27 07:07:46 PST
(In reply to comment #2) > (From update of attachment 180748 [details]) > Attachment 180748 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15542218 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Yeah ... no.
Xan Lopez
Comment 4 2013-01-04 01:55:32 PST
Just a question, if the configure.ac/makefile bits have no effect how can removing them make a test pass? other than that I support getting rid of them.
Zan Dobersek
Comment 5 2013-01-04 03:06:51 PST
(In reply to comment #4) > Just a question, if the configure.ac/makefile bits have no effect how can removing them make a test pass? other than that I support getting rid of them. Here's the AC_ARG_ENABLE prototype: > — Macro: AC_ARG_ENABLE (feature, help-string, [action-if-given], [action-if-not-given]) The `enable_css_transforms_animations_transitions_unprefixed` variable is only set to "yes" if the feature is not passed through the arguments. However, current code lists `xslt` as the 'feature', and that is given, so the default value is not assigned. That's why the Automake conditional was not set up and that resulted in the feature define (1 by default) being overriden with a 0 value.
Xan Lopez
Comment 6 2013-01-04 04:09:30 PST
Comment on attachment 180748 [details] Patch Hah, I see, that's amusing actually. r=me
Zan Dobersek
Comment 7 2013-01-04 06:16:44 PST
Comment on attachment 180748 [details] Patch Clearing flags on attachment: 180748 Committed r138795: <http://trac.webkit.org/changeset/138795>
Zan Dobersek
Comment 8 2013-01-04 06:16:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.