Summary: | [TexMap] Remove ParentChange in TextureMapperLayer. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dongseong Hwang <dongseong.hwang> | ||||
Component: | Layout and Rendering | Assignee: | Dongseong Hwang <dongseong.hwang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, kenneth, noam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 110211 | ||||||
Attachments: |
|
Description
Dongseong Hwang
2012-12-19 21:39:05 PST
Created attachment 180278 [details]
Patch
Comment on attachment 180278 [details] Patch Clearing flags on attachment: 180278 Committed r138291: <http://trac.webkit.org/changeset/138291> All reviewed patches have been landed. Closing bug. This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children. (In reply to comment #4) > This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children. Wasn't it committed 9 months ago? (In reply to comment #5) > (In reply to comment #4) > > This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children. > > Wasn't it committed 9 months ago? Yes, but after the branch of QtWebKit for 5.0/5.1. And it didn't get cherry-picked because it sounded like a refactoring not a bug-fix. Just venting a bit because I just spend half a week tracking this issue down for a customer. |