Bug 105457

Summary: Ref test images are upside-down in WebKit2
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, simon.fraser, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r138187%20(4264)/fast/css/sticky/inline-sticky-abspos-child-diffs.html
Attachments:
Description Flags
Patch sam: review+

Simon Fraser (smfr)
Reported 2012-12-19 13:20:27 PST
When showing failure images for ref tests for WK2 tests, the images are flipped (upside-down). This implies that we're comparing upside-down images, which is harmless but wrong.
Attachments
Patch (1.62 KB, patch)
2013-01-17 13:31 PST, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-12-29 11:03:40 PST
This is still occurring on Mac (looking at the builder output), but I can't reproduce it on GTK. Seems as it's Mac-specific.
Simon Fraser (smfr)
Comment 2 2013-01-17 12:55:55 PST
--pixel-test images are also flipped, breaking all pixel tests :(
Simon Fraser (smfr)
Comment 3 2013-01-17 13:31:45 PST
Created attachment 183260 [details] Patch
Simon Fraser (smfr)
Comment 4 2013-01-17 16:13:15 PST
http://trac.webkit.org/changeset/140067
Note You need to log in before you can comment on or make changes to this bug.