Bug 105456 – [Regression] text-overflow ellipsis clips content when zoomed

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Emil A Eklund]

At certain zoom levels text-overflow ellipsis incorrectly clips content and displays the ellipsis even though the full content would fit.

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=144057

[Emil A Eklund]

Created attachment 180214 [details]
Patch

[Levi Weintraub]

Comment on attachment 180214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180214&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3203
> +        // FIXME: Use pixelSnappedLogicalRightOffsetForLine instead of snapping it ourselves once the column workaround in said method has been fixed.
> +        int blockRightEdge = logicalRightOffsetForLine(curr->lineTop(), firstLine).round();

Emil and I discussed using pixel snapping methods instead of .round() to make this clearer. I'd also like a bug for the column issue so these two fixmes can be tied together better.

[Emil A Eklund]

Created attachment 180219 [details]
Patch

[Emil A Eklund]

Committed r138196: <http://trac.webkit.org/changeset/138196>

[Mark Rowe (bdash)]

This appears to have caused unnecessarily ellipsization on a number of websites. See bug 105600 for information.