Bug 105420

Summary: [Qt] Move ImageDiff to the Tools directory root
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit QtAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, laszlo.gombos, ossy, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 105303    
Attachments:
Description Flags
Patch
none
Patch none

Thiago Marcos P. Santos
Reported 2012-12-19 05:23:21 PST
More details on the Meta bug blocked by this bug.
Attachments
Patch (15.62 KB, patch)
2012-12-19 06:38 PST, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Patch (15.62 KB, patch)
2012-12-19 06:39 PST, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-12-19 06:38:28 PST
Created attachment 180157 [details] Patch
Thiago Marcos P. Santos
Comment 2 2012-12-19 06:39:10 PST
Created attachment 180158 [details] Patch The original ImageDiff code was kept untouched for the sake of git being able to track renames. I'm expecting it to fail on the style checker.
WebKit Review Bot
Comment 3 2012-12-19 06:41:51 PST
Attachment 180158 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/q..." exit_code: 1 Tools/ImageDiff/qt/ImageDiff.cpp:21: Alphabetical sorting problem. [build/include_order] [4] Tools/ImageDiff/qt/ImageDiff.cpp:57: One line control clauses should not use braces. [whitespace/braces] [4] Tools/ImageDiff/qt/ImageDiff.cpp:123: One line control clauses should not use braces. [whitespace/braces] [4] Tools/ImageDiff/qt/ImageDiff.cpp:140: Missing space inside { }. [whitespace/braces] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Laszlo Gombos
Comment 4 2012-12-19 07:04:08 PST
Comment on attachment 180158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180158&action=review > Tools/ChangeLog:11 > + * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro. Perhaps we should move ImageDiff.pro under ImageDiff/qt/ as it was in the previous location under DumpRenderTree/.
Thiago Marcos P. Santos
Comment 5 2012-12-19 08:26:02 PST
Comment on attachment 180158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180158&action=review >> Tools/ChangeLog:11 >> + * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro. > > Perhaps we should move ImageDiff.pro under ImageDiff/qt/ as it was in the previous location under DumpRenderTree/. I tried to make it consistent to WebKitTestRunner that has the .pro located at WebKitTestRunner/WebKitTestRunner.pro
Tor Arne Vestbø
Comment 6 2012-12-20 06:52:31 PST
Comment on attachment 180158 [details] Patch lgtm
WebKit Review Bot
Comment 7 2012-12-20 07:29:32 PST
Comment on attachment 180158 [details] Patch Clearing flags on attachment: 180158 Committed r138253: <http://trac.webkit.org/changeset/138253>
WebKit Review Bot
Comment 8 2012-12-20 07:29:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.