| Summary: | [EFL][WK2] Move deviceScaleFactor to our view as it's view related | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||
| Component: | WebKit EFL | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gyuyoung.kim, laszlo.gombos, lucas.de.marchi, menard, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Kenneth Rohde Christiansen
2012-12-19 04:16:11 PST
Created attachment 180130 [details]
Patch
Comment on attachment 180130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180130&action=review Looks good to me but I would appreciate to address the comments below. > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292 > +void EwkViewImpl::setDeviceScaleFactor(float scale) Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ? > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302 > + // Note that the scale factor incl page and device scale for now. Nit: incl -> includes > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292 > > +void EwkViewImpl::setDeviceScaleFactor(float scale) > > Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ? Yeah, because that is an implementation detail. There exists two methods. Elsewhere it is called by the shorter name. > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302 > > + // Note that the scale factor incl page and device scale for now. > > Nit: incl -> includes Tried to keep the line short. Comment on attachment 180130 [details] Patch Clearing flags on attachment: 180130 Committed r138146: <http://trac.webkit.org/changeset/138146> All reviewed patches have been landed. Closing bug. |