Bug 105389

Summary: Web Inspector: AuditLauncherView UI components should be disabled until ongoing audit finishes
Product: WebKit Reporter: Vivek Galatage <vivekg>
Component: Web Inspector (Deprecated)Assignee: Vivek Galatage <vivek.vg>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vivek.vg, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Vivek Galatage
Reported 2012-12-18 22:40:30 PST
Currently when we are running audits, the button changes its label to "Stop". So we can trigger cancelling of the ongoing audit request. At the same time, the check-boxes for the category are enabled. So if the user de-selects every category while the request is still on going, the "Stop" button becomes disabled. Hence the audit request cannot be cancelled. This can be avoided if AuditLauncherView UI components are disabled until ongoing audit finishes. Patch follows.
Attachments
Patch (4.31 KB, patch)
2012-12-18 23:09 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (4.36 KB, patch)
2012-12-18 23:16 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-12-18 23:09:26 PST
Created attachment 180097 [details] Patch
Vivek Galatage
Comment 2 2012-12-18 23:16:41 PST
Created attachment 180099 [details] Patch
WebKit Review Bot
Comment 3 2012-12-18 23:39:00 PST
Comment on attachment 180099 [details] Patch Clearing flags on attachment: 180099 Committed r138122: <http://trac.webkit.org/changeset/138122>
WebKit Review Bot
Comment 4 2012-12-18 23:39:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.