Bug 105349

Summary: [Chromium/Skia] Check whether bitmap has pixels in image encoders
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: New BugsAssignee: Brian Salomon <bsalomon>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Brian Salomon
Reported 2012-12-18 14:21:57 PST
[Chromium/Skia] Check whether bitmap has pixels in image encoders
Attachments
Patch (3.23 KB, patch)
2012-12-18 14:24 PST, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2012-12-19 05:37 PST, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2012-12-18 14:24:52 PST
Created attachment 180026 [details] Patch
Brian Salomon
Comment 2 2012-12-18 14:27:28 PST
Related cr bug: http://crbug.com/162551
Brian Salomon
Comment 3 2012-12-19 05:37:13 PST
Created attachment 180144 [details] Patch
Brian Salomon
Comment 4 2012-12-19 05:38:49 PST
The failure case was toDataURL on canvas2D when the allocating the readback bitmap failed.
Stephen White
Comment 5 2012-12-19 09:06:36 PST
Comment on attachment 180144 [details] Patch Looks good. r=me For testing this type of thing in the future, perhaps we could think about creating a mock SkPixelRef that leaves its pixels NULL when locked.
WebKit Review Bot
Comment 6 2012-12-19 09:17:54 PST
Comment on attachment 180144 [details] Patch Clearing flags on attachment: 180144 Committed r138170: <http://trac.webkit.org/changeset/138170>
WebKit Review Bot
Comment 7 2012-12-19 09:17:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.