Bug 105340

Summary: Add a JSScriptRef API to JSC so that we can allow API users to avoid the full cost of reparsing everytime the execute a script.
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, gyuyoung.kim, oliver, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch barraclough: review+

Oliver Hunt
Reported 2012-12-18 13:20:38 PST
Add a JSScriptRef API to JSC so that we can allow API users to avoid the full cost of reparsing everytime the execute a script.
Attachments
Patch (22.66 KB, patch)
2012-12-18 13:49 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (22.56 KB, patch)
2012-12-18 17:23 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-12-18 13:49:22 PST
Created attachment 180016 [details] Patch
WebKit Review Bot
Comment 2 2012-12-18 13:53:55 PST
Attachment 180016 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSScriptRef.cpp'..." exit_code: 1 Source/JavaScriptCore/API/JSScriptRefPrivate.h:53: The parameter name "globalContext" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSScriptRefPrivate.h:65: The parameter name "globalContext" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSScriptRefPrivate.h:73: The parameter name "script" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSScriptRefPrivate.h:81: The parameter name "script" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSScriptRefPrivate.h:92: The parameter name "script" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 5 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2012-12-18 17:23:37 PST
Created attachment 180066 [details] Patch
WebKit Review Bot
Comment 4 2012-12-18 17:28:32 PST
Attachment 180066 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSScriptRef.cpp'..." exit_code: 1 Source/JavaScriptCore/API/JSScriptRefPrivate.h:73: The parameter name "script" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSScriptRefPrivate.h:81: The parameter name "script" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSScriptRefPrivate.h:92: The parameter name "script" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 5 2012-12-18 18:20:36 PST
Committed r138098: <http://trac.webkit.org/changeset/138098>
Note You need to log in before you can comment on or make changes to this bug.