Bug 105334

Summary:

Input elements with default touch handlers don't update handler counts when changing documents

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

UI Events

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, jamesr, jbadics, kevers, mifenton, ojan.autocc, tkent, tonikitoo, webkit-ews, webkit.review.bot, yusufo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jamesr: review+, webkit-ews: commit-queue-
Patch	jamesr: review+, webkit.review.bot: commit-queue-

Levi Weintraub

Reported 2012-12-18 12:03:56 PST

We handled one case in updateType, but not in didMoveToNewDocument.

Attachments
Patch (6.31 KB, patch) 2012-12-18 12:12 PST, Levi Weintraub	jamesr: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch (7.39 KB, patch) 2012-12-18 12:24 PST, Levi Weintraub	jamesr: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Levi Weintraub

Comment 1 2012-12-18 12:12:39 PST

Created attachment 179997 [details] Patch Fixes the bug.

Early Warning System Bot

Comment 2 2012-12-18 12:18:07 PST

Comment on attachment 179997 [details] Patch Attachment 179997 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15404317

Early Warning System Bot

Comment 3 2012-12-18 12:18:24 PST

Comment on attachment 179997 [details] Patch Attachment 179997 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15404318

Levi Weintraub

Comment 4 2012-12-18 12:24:53 PST

Created attachment 180002 [details] Patch Changing the guards on didRemoveTouchEventTargetNode.

WebKit Review Bot

Comment 5 2012-12-18 17:29:31 PST

Comment on attachment 180002 [details] Patch Attachment 180002 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15413342 New failing tests: fast/events/touch/touch-input-element-change-documents.html

Levi Weintraub

Comment 6 2012-12-18 18:05:08 PST

Committed r138095: <http://trac.webkit.org/changeset/138095>

János Badics

Comment 7 2012-12-19 02:09:26 PST

The test you have added in r138095 and corrected in r138115 still fails on Qt and EFL. I have added detailed information about the fails at https://bugs.webkit.org/show_bug.cgi?id=105406. Could you have a look at it please? I will skip this test on Qt until the proper fix. Please unskip it afterwards.

János Badics

Comment 8 2012-12-19 02:32:40 PST

fast/events/touch/touch-input-element-change-documents.html has been skipped in r138134. Please unskip with the proper fix.

Note You need to log in before you can comment on or make changes to this bug.