Bug 105332

Summary: TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Tools / TestsAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, noel.gordon
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2012-12-18 11:23:22 PST
[ RUN ] WebCore.LayoutUnitDivision ../src/gtest.cc:2022: Failure Failed All tests in the same test case must use the same test fixture class, so mixing TEST_F and TEST in the same test case is illegal. In test case WebCore, test KURLConstructorDefault is defined using TEST_F but test LayoutUnitDivision is defined using TEST. You probably want to change the TEST to TEST_F or move it to another test case.
Attachments
Patch (3.03 KB, patch)
2012-12-18 11:24 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.93 KB, patch)
2012-12-18 11:55 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-12-18 11:24:49 PST
Created attachment 179984 [details] Patch
Levi Weintraub
Comment 2 2012-12-18 11:33:40 PST
Comment on attachment 179984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179984&action=review > Tools/ChangeLog:10 > + compatible with KURL tests as one cannot mix the two types in > + the same test suite. Sad panda!
Emil A Eklund
Comment 3 2012-12-18 11:55:17 PST
Created attachment 179994 [details] Patch for landing
Emil A Eklund
Comment 4 2012-12-18 12:05:16 PST
Moved to separate test suite instead as suggested.
Emil A Eklund
Comment 5 2012-12-18 12:08:54 PST
Committed r138050: <http://trac.webkit.org/changeset/138050>
Note You need to log in before you can comment on or make changes to this bug.