Bug 105322

Summary: [GTK] Enable Navigation Timing by default
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2012-12-18 10:01:35 PST
The Navigation Timing spec has just recently been promoted to W3C Recommendation status. http://www.w3.org/News/2012#entry-9668 The feature is guarded by the ENABLE_WEB_TIMING feature define. I think it would make sense to now enable it by default in release builds as well.
Attachments
Patch (1.43 KB, patch)
2012-12-18 10:40 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.02 KB, patch)
2012-12-18 11:13 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-12-18 10:40:43 PST
Created attachment 179976 [details] Patch
Zan Dobersek
Comment 2 2012-12-18 10:56:00 PST
Comment on attachment 179976 [details] Patch Also requires modifications to the GObject bindings GNUmakefile, will upload a new patch.
Zan Dobersek
Comment 3 2012-12-18 11:13:17 PST
Created attachment 179982 [details] Patch
Martin Robinson
Comment 4 2012-12-18 11:15:27 PST
Comment on attachment 179982 [details] Patch Looks good. Is this enabled on Chromium?
Zan Dobersek
Comment 5 2012-12-18 11:24:05 PST
(In reply to comment #4) > (From update of attachment 179982 [details]) > Looks good. Is this enabled on Chromium? Yes. http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi#L129 Can also exercise the feature in the latest Chromium release from the dev channel.
Zan Dobersek
Comment 6 2012-12-19 08:35:05 PST
Comment on attachment 179982 [details] Patch Clearing flags on attachment: 179982 Committed r138167: <http://trac.webkit.org/changeset/138167>
Zan Dobersek
Comment 7 2012-12-19 08:35:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.