Bug 105321

Summary: [CSS Shaders] Detached identifier after mesh box type is not applied
Product: WebKit Reporter: Max Vujovic <mvujovic>
Component: Layout and RenderingAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, cmarcelo, macpherson, menard, michelangelo, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Max Vujovic 2012-12-18 10:00:44 PST 
If the "detached" identifier follows a mesh box type identifier, the detached identifier is not applied. In other words, the mesh is still attached. For example:
-webkit-filter: custom(url(shader.vs) mix(url(shader.fs) normal source-atop), 1 1 border-box detached);

Although the mesh box type is being removed from the Filter Effects spec, for now, we continue to accept the mesh box type in parsing because of existing content. Eventually, custom filters will transition to an at-rule syntax, once it is defined.

Patch coming up.
Comment 1 Max Vujovic 2013-01-03 09:52:23 PST 
Created attachment 181181 [details]
Patch
Comment 2 Max Vujovic 2013-01-09 15:04:03 PST 
Comment on attachment 181181 [details]
Patch

Thanks for the review! Setting cq+.
Comment 3 WebKit Review Bot 2013-01-09 15:15:12 PST 
Comment on attachment 181181 [details]
Patch

Clearing flags on attachment: 181181

Committed r139248: <http://trac.webkit.org/changeset/139248>
Comment 4 WebKit Review Bot 2013-01-09 15:15:15 PST 
All reviewed patches have been landed.  Closing bug.