Bug 105316

Summary: [WK2] Create a context client
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebKit2Assignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, ap, beidson, cmarcelo, gyuyoung.kim, menard, rakuco, sam, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.8   
Attachments:
Description Flags
Patch beidson: review+

Description Jon Lee 2012-12-18 09:18:00 PST 
The web context basically currently has two clients: a download client and a history client. Create a third generic client where miscellaneous calls can be aggregated.
Comment 1 Radar WebKit Bug Importer 2012-12-18 09:18:14 PST 
<rdar://problem/12901762>
Comment 2 Jon Lee 2012-12-18 09:54:07 PST 
Created attachment 179969 [details]
Patch
Comment 3 WebKit Review Bot 2012-12-18 10:00:56 PST 
Attachment 179969 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/UIProcess/API/C/WKContext.h:49:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Sam Weinig 2012-12-18 10:01:58 PST 
What will go in this client?  Without any context, I am not sure how to review this patch.
Comment 5 Jon Lee 2012-12-18 10:09:07 PST 
A function to notify the context client that the table of auto-start origin hashes has changed.
Comment 6 Brady Eidson 2012-12-18 16:00:43 PST 
Comment on attachment 179969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179969&action=review

r+ with one requested change.

> Source/WebKit2/UIProcess/WebContext.h:374
>      WebHistoryClient m_historyClient;
> +    WebDownloadClient m_downloadClient;
> +    WebContextClient m_client;

Might as well sort these alphabetically as long as you're rearranging them.
Comment 7 Jon Lee 2012-12-18 18:13:23 PST 
Committed r138096: <http://trac.webkit.org/changeset/138096>